fix: race conditions in usePersistedDevicePreferences #1575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mounting and unmounting
usePersistedDevicePreferences
hook in quick succession, the following race conditions can occur:useApplyDevicePreferences
can apply stale preferences, since the effect it runs is async and is not canceled on unmount.usePersistDevicePreferences
can write new device preferences (most likely, the default ones) before they were applied.This is fixed by adding cancelation to the effect in
useApplyDevicePreferences
, and by preventingusePersistDevicePreferences
from running beforeuseApplyDevicePreferences
completes.